Browse source

Changelog

Query
From:
To:
Branch:
Path:
Message:
BugID:
User: +
Format:
: 166 checkins (+833/-1234) by 4 people : 23 checkins (+237/-42) by 3 people : 9 checkins (+93/-5) by 2 people : 1 checkin (+21/-2) by Henrik Grubbström (Grubba) <grubba@grubba.org> : 5 checkins (+60/-13) by 2 people : 31 checkins (+1493/-149) by 3 people : 34 checkins (+445/-87) by 2 people : 17 checkins (+1044/-8) by 3 people : 7 checkins (+22/-15) by 2 people : 1 checkin (+3/-1) by Henrik Grubbström (Grubba) <grubba@grubba.org> : 4 checkins (+18/-7) by 3 people : 2 checkins (+85/-0) by Henrik Grubbström (Grubba) <grubba@grubba.org> : 2 checkins (+7/-4) by 2 people : 1 checkin (+3/-1) by Henrik Grubbström (Grubba) <grubba@grubba.org> : 1 checkin (+1/-10) by Henrik Grubbström (Grubba) <grubba@grubba.org> : 5 checkins (+27/-23) by 2 people : 5 checkins (+148/-11) by 2 people : 6 checkins (+84/-50) by 2 people : 19 checkins (+123/-42) by 3 people : 5 checkins (+24/-7) by 2 people : 14 checkins (+116/-53) by 3 people : 10 checkins (+40/-14) by 3 people : 28 checkins (+1095/-373) by 3 people : 23 checkins (+38/-1165) by 3 people : 216 checkins (+2364/-374) by 7 people : 28 checkins (+404/-149) by 4 people : 44 checkins (+271/-3650) by 5 people : 5 checkins (+83/-12) by 3 people : 17 checkins (+102/-31) by 3 people : 8 checkins (+154/-105) by 2 people : 51 checkins (+820/-262) by 4 people : 10 checkins (+194/-105) by 3 people : 28 checkins (+496/-402) by 3 people : 5 checkins (+120/-36) by 3 people : 29 checkins (+459/-369) by 5 people : 17 checkins (+117/-66) by 3 people : 109 checkins (+4819/-2612) by 4 people : 3 checkins (+15/-3) by 2 people : 2 checkins (+34/-8) by Henrik Grubbström (Grubba) <grubba@grubba.org> : 168 checkins (+1943/-1585) by 5 people : 44 checkins (+2488/-1767) by 3 people Lines added/removed recently

Today; Tuesday 21 November 2017

2017-11-21 16:26:24 (2 hours ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Configure [GL.GLSL]: Fix build problems on some platforms.

Make sure that the <GL/gl.h> header file can be found.

2017-11-21 12:38:58 (6 hours ago) by Tobias Liin <liin@roxen.com>

release number bumped to 8.0.511 by export.pike
release number bumped to 8.0.510 by export.pike

2017-11-21 11:02:34 (8 hours ago) by Stephen R. van den Berg <srb@cuci.nl>

Doc fixes.
Paint over some PikeParser bugs during make doc.

2017-11-21 10:58:25 (8 hours ago) by Stephen R. van den Berg <srb@cuci.nl>

Doc fixes.
Paint over some PikeParser bugs during make doc.

2017-11-21 10:20:38 (8 hours ago) by Stephen R. van den Berg <srb@cuci.nl>

Update CHANGES.

2017-11-21 10:08:09 (8 hours ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

SSL.File: Added support for set_buffer_mode().

Adds support for user provided buffers in both directions.

Updates the {read,write,close}_callbacks to the current conventions of
Stdio.File (this includes defaulting the callback_id to this_object()).

Also adds some corresponding tests to the testsuite.

2017-11-21 10:05:01 (9 hours ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Add diagnostics.
SSL.File: Fix docs.

2017-11-21 10:00:58 (9 hours ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Add diagnostics.

2017-11-21 09:38:54 (9 hours ago) by Stephen R. van den Berg <srb@cuci.nl>

Sql.Sql: Support error(void|int clear), fix typo(3).

2017-11-21 03:31:53 (15 hours ago) by Stephen R. van den Berg <srb@cuci.nl>

Sql.Sql: Support error(void|int clear), fix typo(2).

2017-11-21 03:27:16 (15 hours ago) by Stephen R. van den Berg <srb@cuci.nl>

Sql.Sql: Support error(void|int clear), fix typo.

2017-11-21 03:22:25 (15 hours ago) by Stephen R. van den Berg <srb@cuci.nl>

Update CHANGES.

2017-11-21 02:26:52 (16 hours ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Create proxy object to avoid circular references.
Thread.ResourceCount: New module to implement resource counters.
Crypto.SCRAM: New module.
pgsql: Simplify and bolster the code by using Thread.ResourceCount.
pgsql: Make SSL fix 8.0 compatible.

2017-11-21 02:14:56 (16 hours ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Remove leftover diagnostics.

2017-11-21 02:01:17 (17 hours ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Fix SSL method in combination with Stdio.Buffer.

2017-11-21 01:58:08 (17 hours ago) by Stephen R. van den Berg <srb@cuci.nl>

SSL.File: Implement query_fd().
pgsql: Eliminate connectfail() backreferences.

2017-11-21 01:46:33 (17 hours ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Update documentation.

2017-11-21 00:48:05 (18 hours ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Create proxy object to avoid circular references.
Debug.refs: Protect against non-refcounted parameters.
pgsql: Eliminate connectfail() backreferences.
SSL.File: Implement query_fd().
Crypto.SCRAM: Inline constants since they are referenced only once now.
pgsql: Fix SSL method in combination with Stdio.Buffer.
Sql.Sql: Support error(void|int clear).

Yesterday; Monday 20 November 2017

2017-11-20 20:51:46 (22 hours ago) by Martin Nilsson <nilsson@fastmail.com>

Checked with Python.

2017-11-20 19:22:11 (23 hours ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Merge branch 'patches/ws85' into devel

* patches/ws85:
Core: Improved diagnostics for the certificate scanner.

2017-11-20 19:12:23 (23 hours ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Core: Improved diagnostics for the certificate scanner.

2017-11-20 17:56:53 (1 day ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Testsuite [Crypto]: Added some vectors for SHA256.

2017-11-20 16:01:10 (1 day ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Merge branch 'patches/ftp' into devel

* patches/ftp:
FTP: Avoid multiple close callbacks.

2017-11-20 15:56:05 (1 day ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

FTP: Avoid multiple close callbacks.

Under some circumstances TelnetSession could apparently restore
the close callback after it had been removed, causing it to be
called multiple (sometimes on the order of 1000s) times before
the connection actually gets shut down.

Potential fix for [WS-99].

2017-11-20 15:51:58 (1 day ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Merge commit '8468d07e63a61e80c5a7916ab61c0f25135ac2fc' into patches/ftp

Synch with Roxen 6.0/6.1 split.

* commit '8468d07e63a61e80c5a7916ab61c0f25135ac2fc': (428 commits)

2017-11-20 14:49:47 (1 day ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Merge branch 'patches/ftp' into devel

* patches/ftp:
FTP: Added some comments.
FTP: Don't look up the content-type if not required.
FTP: Consistent case for the "type" fact.
FTP: Added facts UNIX.atime and UNIX.ctime.
FTP: Support the defacto facts UNIX.uid and UNIX.gid.
FTP: The UNIX.mode defacto fact should be in octal.
FTP: Implement OPTS MLST.
FTP: Fixed case-sensitivity bug in HELP.
FTP: Implemented support for the OPTS command.
FTP: Fixed output from FEAT MLST.
FTP: Fixed syntax error in fact list output from MLST/MLSD.
FTP: Added some comments.

2017-11-20 14:47:13 (1 day ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

FTP: Don't look up the content-type if not required.
FTP: Consistent case for the "type" fact.

2017-11-20 14:43:15 (1 day ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

FTP: Added facts UNIX.atime and UNIX.ctime.

2017-11-20 14:40:53 (1 day ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

FTP: Support the defacto facts UNIX.uid and UNIX.gid.

Also adjusts the default set of facts returned by MLST and MLSD.

2017-11-20 14:36:27 (1 day ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

FTP: The UNIX.mode defacto fact should be in octal.

2017-11-20 14:32:25 (1 day ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

FTP: Implement OPTS MLST.

It is now possibly to specify what facts that MLST and MLSD should return.

Fixes [WS-101].

2017-11-20 14:25:30 (1 day ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

FTP: Fixed case-sensitivity bug in HELP.

The detailed help for the SITE and OPTS commands needed the
command names "SITE" and "OPTS" to be speicified in upper case.

2017-11-20 14:22:01 (1 day ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

FTP: Implemented support for the OPTS command.

2017-11-20 14:13:10 (1 day ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

FTP: Fixed output from FEAT MLST.

The default set of facts was not marked with asterisks ('*').

Prepare for supporting OPTS MLST.

2017-11-20 14:08:24 (1 day ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

FTP: Fixed syntax error in fact list output from MLST/MLSD.

The terminating ';' was missing.

2017-11-20 14:04:28 (1 day ago) by Jonas Walldén <jonasw@roxen.com>

Censor FTP password when sent to roxen.handle().

2017-11-20 14:04:20 (1 day ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Merge branch 'patches/bug7229' into patches/ftp

* patches/bug7229:
FTP: Fixed bug in MLSD/MLST handling.

2017-11-20 09:30:38 (1 day ago) by Stefan Wallström <stewa@roxen.com>

PUT for configuration variables

Sunday 19 November 2017

2017-11-19 15:40:34 (2 days ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Testsuite: Fixed some typos in previous commit.

2017-11-19 11:56:12 (2 days ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Testsuite: Test Crypto.Hash.HMAC.

Saturday 18 November 2017

2017-11-18 13:41:58 (3 days ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Nettle.Hash.HMAC: Fix non-default block_sizes().

Fall back to the default (generic) HMAC implementation if
a non-standard block_size() is requested.

Fixes [LysLysKOM 22249286].

Thanks to Stephen R. van den Berg <srb@cuci.nl> for reporting the issue.

Also adds some related documentation.

2017-11-18 06:04:40 (4 days ago) by Martin Nilsson <nilsson@fastmail.com>

Removed unused includes.

Friday 17 November 2017

2017-11-17 19:12:41 (4 days ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Updated to 2017c.

2017-11-17 19:07:36 (4 days ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Updated to 2017c.

2017-11-17 16:51:27 (4 days ago) by Stefan Wallström <stewa@roxen.com>

get config level variables

2017-11-17 16:21:53 (4 days ago) by Stefan Wallström <stewa@roxen.com>

module actions

2017-11-17 15:49:39 (4 days ago) by Stefan Wallström <stewa@roxen.com>

Disable module

2017-11-17 15:42:27 (4 days ago) by Stefan Wallström <stewa@roxen.com>

Add module endpoint

2017-11-17 14:07:03 (4 days ago) by Stefan Wallström <stewa@roxen.com>

PUT variables

2017-11-17 13:36:57 (4 days ago) by Stefan Wallström <stewa@roxen.com>

Fixed code duplication

2017-11-17 11:55:03 (4 days ago) by Anders Johansson <anders@roxen.com>

Merge branch 'patches/ep302' into 6.1

* patches/ep302:
FSGC: Avoid using DefaultMonitor implementation [EP-329]
FSGC: Fixed some typos.
FSGC [DEBUG]: Don't claim that the root directory is getting deleted.
FSGC: Pedantic threshold fix.
FSGC: Restore stable change notification after override.
FSGC: Override accelerated stable change notification [EP-327]

2017-11-17 11:42:29 (4 days ago) by Karl Gustav Sterneberg <kg@roxen.com>

HTTPClient: Now supports setting follow_redirects.
You can now specify the max number of times redirects will be
followed.
Changed return type for roxen->get_locale() from mixed to string.

2017-11-17 11:30:56 (4 days ago) by Stefan Wallström <stewa@roxen.com>

Reimplemented some endpoints using router
Disable test endpoints
Define to enable old non-router endpoints

2017-11-17 11:21:51 (4 days ago) by Anders Johansson <anders@roxen.com>

Merge branch 'patches/ep302' into devel

* patches/ep302:
FSGC: Avoid using DefaultMonitor implementation [EP-329]
FSGC: Avoid using DefaultMonitor implementation [EP-329]

2017-11-17 11:17:43 (4 days ago) by Karl Gustav Sterneberg <kg@roxen.com>

Merge branch 'devel' into kg/archive-client

Thursday 16 November 2017

2017-11-16 16:33:47 (5 days ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Merge branch 'patches/ep302' into devel

* patches/ep302:
FSGC: Fixed some typos.
FSGC: Fixed some typos.

2017-11-16 16:23:53 (5 days ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Merge branch 'patches/ep302' into devel

* patches/ep302:
FSGC [DEBUG]: Don't claim that the root directory is getting deleted.
FSGC: Pedantic threshold fix.
FSGC: Restore stable change notification after override.

2017-11-16 16:21:13 (5 days ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

FSGC [DEBUG]: Don't claim that the root directory is getting deleted.
FSGC: Pedantic threshold fix.

2017-11-16 16:17:59 (5 days ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

FSGC: Restore stable change notification after override.

Fixes [EP-329] Comment #1.

2017-11-16 16:09:18 (5 days ago) by Anders Johansson <anders@roxen.com>

FSGC: Override accelerated stable change notification [EP-327]

2017-11-16 12:02:39 (5 days ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Tools.Standalone.check_http: Add support for option --expect.

Support matching against the response status line.

2017-11-16 11:57:15 (5 days ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Tools.Standalone.check_http: Allow redirect responses.

Some HTTP-servers only ever return redirects...

Fixes [PIKE-44].

2017-11-16 11:13:46 (5 days ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Tools.Standalone.check_http: Add support for option --expect.

Support matching against the response status line.

2017-11-16 11:10:33 (5 days ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Tools.Standalone.check_http: Allow redirect responses.

Some HTTP-servers only ever return redirtects...

Fixes [PIKE-44].

2017-11-16 02:17:41 (6 days ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Run _lost callbacks on TCP-resets.
pgsql: Run _lost callbacks on TCP-resets.

2017-11-16 01:41:24 (6 days ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Update docs.

2017-11-16 01:38:26 (6 days ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Update docs.

Wednesday 15 November 2017

2017-11-15 21:21:17 (6 days ago) by Martin Nilsson <nilsson@fastmail.com>

Removed pointless Stdio.Buffer API. Less complex code and equal performancewise.

2017-11-15 20:04:20 (6 days ago) by Stephen R. van den Berg <srb@cuci.nl>

Crypto.SCRAM: Type checking/casting blues.

2017-11-15 19:14:56 (6 days ago) by Martin Nilsson <nilsson@fastmail.com>

Improved types and visibility modifiers

2017-11-15 17:09:23 (6 days ago) by Stefan Wallström <stewa@roxen.com>

List databases. Create database and database group.

2017-11-15 17:03:48 (6 days ago) by Anders Johansson <anders@roxen.com>

FSGC: Override accelerated stable change notification [EP-327]

2017-11-15 16:58:11 (6 days ago) by Stefan Wallström <stewa@roxen.com>

Use X-HTTP-Method-Override header

2017-11-15 16:53:03 (6 days ago) by Stephen R. van den Berg <srb@cuci.nl>

Debug.Inspect: Allow forced dumps.
pgsql: Rip out fundamentally flawed reconnect logic, make failures consistent.
Update CHANGES.

2017-11-15 16:50:43 (6 days ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Suppress errors in destructed objects(2).

2017-11-15 16:49:26 (6 days ago) by Stefan Wallström <stewa@roxen.com>

Print backtrace when MODULE_DEBUG is defined
Router: decode data from client

2017-11-15 16:47:35 (6 days ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Suppress errors in destructed objects.

2017-11-15 16:41:26 (6 days ago) by Anders Johansson <anders@roxen.com>

FSGC: Override accelerated stable change notification [EP-327]

2017-11-15 16:28:13 (6 days ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Calendar: Updated mkrules filter to latest set of tzdata files.
Calendar: Updated mkrules filter to latest set of tzdata files.

2017-11-15 15:58:41 (6 days ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Rip out fundamentally flawed reconnect logic, make failures consistent.

2017-11-15 13:03:02 (6 days ago) by Stefan Wallström <stewa@roxen.com>

Feed router with simple patterns instead of regexps

2017-11-15 11:04:20 (6 days ago) by Stephen R. van den Berg <srb@cuci.nl>

Debug.Inspect: Allow forced dumps.

2017-11-15 09:54:55 (6 days ago) by Stefan Wallström <stewa@roxen.com>

get database group

2017-11-15 09:46:36 (6 days ago) by Stefan Wallström <stewa@roxen.com>

Bugfix router reponse code

2017-11-15 09:25:24 (6 days ago) by Stefan Wallström <stewa@roxen.com>

list databasegroups
Handle router exceptions

2017-11-15 09:22:57 (6 days ago) by Stefan Wallström <stewa@roxen.com>

Formatting

Tuesday 14 November 2017

2017-11-14 18:59:34 (7 days ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Compiler: Fixed typo in previous commit.

2017-11-14 18:55:19 (7 days ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Compiler: Improved variant robustness.

Perform a more lenient scan for the previous definition
of a variant in the second pass.

Should fix issues with not finding variants in the second
pass, causing the fatal "Internal error: Not allowed to
add more identifiers during second compiler pass."

2017-11-14 18:31:25 (1 week ago) by Stephen R. van den Berg <srb@cuci.nl>

Crypto.SCRAM: Simplify code further.

2017-11-14 16:58:35 (1 week ago) by Stefan Wallström <stewa@roxen.com>

Simple request router

2017-11-14 15:40:27 (1 week ago) by Stephen R. van den Berg <srb@cuci.nl>

Crypto.SCRAM: Code reuse client/server.

Monday 13 November 2017

2017-11-13 23:27:48 (1 week ago) by Stephen R. van den Berg <srb@cuci.nl>

Crypto.SCRAM: Type checking/casting blues.

2017-11-13 22:54:49 (1 week ago) by Stephen R. van den Berg <srb@cuci.nl>

Crypto.SCRAM: Type checking/casting blues.

2017-11-13 18:05:27 (1 week ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Compiler: Only check LFUN types in second pass.

2017-11-13 17:18:21 (1 week ago) by Martin Nilsson <nilsson@fastmail.com>

Renamed cnonce to nonce as it is used in both server and client.
Remove untrue comment.
Use #require instead #if constant

2017-11-13 17:05:44 (1 week ago) by Stephen R. van den Berg <srb@cuci.nl>

Crypto.SCRAM: Made robust against rogue input and fix caching mechanism.

2017-11-13 14:48:20 (1 week ago) by Stephen R. van den Berg <srb@cuci.nl>

Crypto.SCRAM: Streamline API and update docs.

2017-11-13 14:04:20 (1 week ago) by Stephen R. van den Berg <srb@cuci.nl>

Crypto.SCRAM: Update docs.

2017-11-13 13:38:02 (1 week ago) by Stephen R. van den Berg <srb@cuci.nl>

Crypto.SCRAM: API updated, implemented serverside and testsuite.

2017-11-13 12:56:59 (1 week ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Merge branch 'patches/ws85' into devel

* patches/ws85:
ConfigIF: Hide the SSL decryption password setting.
ConfigIF: Hide the SSL decryption password setting.

The certificate password has moved to the CertDB.

Fixes [WS-85] some more.

2017-11-13 11:23:18 (1 week ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Merge branch 'patches/ws85' into devel

* patches/ws85:
CertDB: Fixed typo in comment.
CertDB: Clean up low_refresh_pem().
StartTLSProtocol: Added some more notes.
StartTLSProtocol: Removed some disabled code.
ConfigIF: Remove broken action "certs.pike".
CertDB: Update the private key data too.
ConfigIF: Added missing white space in doc.
CertDB: Fixed typo in comment.
CertDB: Clean up low_refresh_pem().

Split low_refresh_pem() into multiple smaller functions.

Fixes some of [WS-91] Issue #10.
StartTLSProtocol: Added some more notes.

Fixes [WS-91] Issue #6 some more.
StartTLSProtocol: Removed some disabled code.

Fixes [WS-91] #5.
ConfigIF: Remove broken action "certs.pike".

This was a remnant of a previous implementation.

Fixes [WS-91] Issues #2 & #9.
CertDB: Update the private key data too.

Fixes the case where the data for an existing private key
has become corrupted.

Fixes [WS-91] Issue #1.

2017-11-13 01:47:34 (1 week ago) by Stephen R. van den Berg <srb@cuci.nl>

Crypto.SCRAM: Avoid specifying the blocksize on HMAC().

Sunday 12 November 2017

2017-11-12 23:07:19 (1 week ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Still allow empty or unspecified credentials.
pgsql: Use Crypto.SCRAM.
Crypto.SCRAM: New module.
pgsql: Still allow empty or unspecified credentials.

2017-11-12 20:33:39 (1 week ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Testsuite: Added some tests of the destroy() warning.

2017-11-12 12:59:32 (1 week ago) by Marcus Comstedt <marcus@mc.pp.se>

Tools.Standalone.features: Add GL.GLSL to checklist

2017-11-12 01:20:59 (1 week ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Slightly reduce memory footprint of the SCRAM-algorithm.

2017-11-12 01:14:53 (1 week ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Slightly reduce memory footprint of the SCRAM-algorithm.

2017-11-12 00:24:25 (1 week ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Make syntax 8.0 compatible.

2017-11-12 00:16:23 (1 week ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Make syntax 8.0 compatible.

Saturday 11 November 2017

2017-11-11 18:41:43 (1 week ago) by Arne Goedeke <el@laramies.com>

GC: reduce padding around marker struct

2017-11-11 17:48:24 (1 week ago) by Arne Goedeke <el@laramies.com>

Added two GC benchmarks

2017-11-11 17:35:01 (1 week ago) by Tobias S. Josefowitz <tobij@tobij.de>

GC: Inline markers into datastructures

Initial work is done. This may have worse performance characteristics
for now. Futher work will use the block allocator provided iterator
instead of linked lists to visit all objects and potentially optimize
the memory layout of the marker struct.

2017-11-11 17:03:49 (1 week ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Make salted-password-cache threadsafe.
pgsql: Make salted-password-cache threadsafe.

2017-11-11 16:32:15 (1 week ago) by Stephen R. van den Berg <srb@cuci.nl>

Updated CHANGES.

2017-11-11 16:26:36 (1 week ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Postgresql 10 scram-SHA256 authentication support.

2017-11-11 16:20:39 (1 week ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Postgresql 10 scram-SHA256 authentication support.

2017-11-11 11:21:31 (1 week ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

encode_value: Don't generate deprecation warnings.

Potential fix for testsuite failures for version compatibility
modules on some platforms.

2017-11-11 02:43:58 (2 weeks ago) by Tobias S. Josefowitz <tobij@tobij.de>

GL.GLSL: Hide GL.GLSL and GL.GLSLUtils when not supported

2017-11-11 02:03:40 (2 weeks ago) by Tobias S. Josefowitz <tobij@tobij.de>

GL.GLSL: Check for the correct libGL to use

This is heavily cargo-culted from post_modules/GL, but should now let
Pike compile on platforms with no libGL.

Friday 10 November 2017

2017-11-10 16:28:26 (2 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Compiler: Let #pragma no_deprecation_warnings inhibit some more.

falling back to destroy() if _detruct() doesn't exist.

2017-11-10 02:48:04 (2 weeks ago) by Stephen R. van den Berg <srb@cuci.nl>

Thread.ResourceCount: Added testsuite.

2017-11-10 01:29:15 (2 weeks ago) by Stephen R. van den Berg <srb@cuci.nl>

MIME: Support trailing \n epilogues on MIME parts.
Revert "pgsql: Signal EOF first, to avoid deadlock on object destruction."

This reverts commit f342376c815d0f060e69fb3aba761e817c9583a1.

The race has instead been fixed correctly by:
pgsql: Cater for race during asynchronous destruction of bufcon.
Revert "pgsql: Signal EOF first, to avoid deadlock on object destruction."

This reverts commit f342376c815d0f060e69fb3aba761e817c9583a1.

The race has instead been fixed correctly by:
pgsql: Cater for race during asynchronous destruction of bufcon.
pgsql: Simplify and bolster the code by using Thread.ResourceCount.
Thread.ResourceCount: New module to implement resource counters.

Thursday 09 November 2017

2017-11-09 16:42:21 (2 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Build: Fixed some warnings when compiling --without-debug.

2017-11-09 16:30:07 (2 weeks ago) by Anders Johansson <anders@roxen.com>

DBManager: Fix for non-existing directory when removing backup [WS-79]

2017-11-09 16:25:32 (2 weeks ago) by Anders Johansson <anders@roxen.com>

DBManager: Don't leave incomplete marker for failed backups [WS-79]

2017-11-09 12:24:01 (2 weeks ago) by Stephen R. van den Berg <srb@cuci.nl>

Updated CHANGES.

2017-11-09 12:21:08 (2 weeks ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Cater for race during asynchronous destruction of bufcon.
pgsql: Inline the various big_query() variants.

2017-11-09 12:15:11 (2 weeks ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Cater for race during asynchronous destruction of bufcon.

2017-11-09 12:07:48 (2 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

ConfigIF: Added missing white space in doc.

2017-11-09 10:11:58 (2 weeks ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Inline the various big_query() variants.

2017-11-09 10:07:00 (2 weeks ago) by Stephen R. van den Berg <srb@cuci.nl>

Spelling fixes.
Spelling fixes.

2017-11-09 03:47:12 (2 weeks ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Signal EOF first, to avoid deadlock on object destruction.
Updated CHANGES.

2017-11-09 03:33:30 (2 weeks ago) by Stephen R. van den Berg <srb@cuci.nl>

pgsql: Signal EOF first, to avoid deadlock on object destruction.

2017-11-09 03:30:23 (2 weeks ago) by Stephen R. van den Berg <srb@cuci.nl>

Change destroy() to _destruct().

Wednesday 08 November 2017

2017-11-08 19:18:40 (2 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Build [Inotify]: Potential fix for missing inotify_config.h.

2017-11-08 14:10:32 (2 weeks ago) by Karl Gustav Sterneberg <kg@roxen.com>

Custom Headers Filter Module. [WS-63]
Custom Headers Filter Module. [WS-63]

Adjustments after QA.

2017-11-08 13:51:00 (2 weeks ago) by Anders Johansson <anders@roxen.com>

Merge branch 'feature/WS-63-custom-header-filter-module' into devel

* feature/WS-63-custom-header-filter-module:
Custom Headers Filter Module. [WS-63]
Custom Headers Filter Module. [WS-63]

2017-11-08 10:42:58 (2 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Build: Fixed syntax error --with-dmalloc.

Tuesday 07 November 2017

2017-11-07 20:28:25 (2 weeks ago) by Marcus Comstedt <marcus@mc.pp.se>

Build: Unbreak config program checks when cross compiling

If --host is specified, unprefixed binaries should not be used.

2017-11-07 17:33:46 (2 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Build: Fixed syntax error --with-dmalloc.

2017-11-07 16:56:42 (2 weeks ago) by Stephen R. van den Berg <srb@cuci.nl>

Unstuffed.

2017-11-07 15:47:24 (2 weeks ago) by Martin Nilsson <nilsson@fastmail.com>

Removed unbug

2017-11-07 15:12:47 (2 weeks ago) by Martin Nilsson <nilsson@fastmail.com>

Remove some more stuff.h that apparently were not tracked by dependencies.

2017-11-07 13:34:40 (2 weeks ago) by Martin Nilsson <nilsson@fastmail.com>

Retire stuff.c/h

2017-11-07 12:18:34 (2 weeks ago) by Anders Johansson <anders@roxen.com>

ConfigIF: Scan for certs when they are likely to change

Done when the path globs are reconfigured, or when the wizards creating
self signed certs has been used.

2017-11-07 11:55:33 (2 weeks ago) by Anders Johansson <anders@roxen.com>

Core: Scan for certs in a handler thread

2017-11-07 11:49:18 (2 weeks ago) by Martin Nilsson <nilsson@fastmail.com>

Move my_strtod to lex
Use wide_isidchar also for non-wide strings.

2017-11-07 11:25:54 (2 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Merge branch 'patches/ws85' into devel

* patches/ws85:
Core: Disabled some certificate scanning debug.
CertDB: Improved diagnostics somewhat.
ConfigIF: Added some more doc for the SSL/TLS certificate selector.
ConfigIF: Hide the old SSL/TLS certificate settings.
CertificateKeyChoiceVariable: Show full source paths
CertificateKeyChoiceVariable: Show source paths
CertificateKeyChoiceVariable: Layout and localization
Core: Disabled some certificate scanning debug.

Fixes some of [WS-87].

2017-11-07 11:01:53 (2 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

CertDB: Improved diagnostics somewhat.
ConfigIF: Added some more doc for the SSL/TLS certificate selector.

2017-11-07 10:59:38 (2 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

ConfigIF: Hide the old SSL/TLS certificate settings.

Fixes remainder of [WS-83].

2017-11-07 10:36:21 (2 weeks ago) by Anders Johansson <anders@roxen.com>

CertificateKeyChoiceVariable: Show full source paths

Also some title case and warning for missing files.
CertificateKeyChoiceVariable: Show source paths
CertificateKeyChoiceVariable: Layout and localization

Monday 06 November 2017

2017-11-06 20:04:56 (2 weeks ago) by Martin Nilsson <nilsson@fastmail.com>

Moved isidchar to stralloc

2017-11-06 19:43:21 (2 weeks ago) by Martin Nilsson <nilsson@fastmail.com>

Moved my_log2 from stuff to cpulib.

2017-11-06 19:30:33 (2 weeks ago) by Martin Nilsson <nilsson@fastmail.com>

Move hashprimes to backend.cmod.

2017-11-06 19:24:14 (2 weeks ago) by Martin Nilsson <nilsson@fastmail.com>

find_next_power is only used by mapping.c. Move it there. Saves 392 bytes\!\!

2017-11-06 19:17:50 (2 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

CHANGES: Updated with current changes.

2017-11-06 18:11:35 (2 weeks ago) by Anders Johansson <anders@roxen.com>

CertificateKeyChoiceVariable: Show full source paths

Also some title case and warning for missing files.

2017-11-06 16:38:16 (2 weeks ago) by Anders Johansson <anders@roxen.com>

CertificateKeyChoiceVariable: Show source paths

2017-11-06 16:21:30 (2 weeks ago) by Anders Johansson <anders@roxen.com>

CertificateKeyChoiceVariable: Layout and localization

2017-11-06 15:12:06 (2 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Configure [GL.GLSL]: Survive without GLSL.

The configure script now no longer aborts if the dependencies
for the GL.GLSL module aren't met.

Also adds a feature line to the main configuration report.

Fixes multiple build failures in Pikefarm.

2017-11-06 14:01:45 (2 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Merge branch 'patches/ws85' into devel

* patches/ws85:
CertDB: Added get_keypair_metadata().
CertDB: Cleaned up types.
CertDB: Added get_keypair_metadata().

Add a function to retreive metadata about keypairs.

2017-11-06 13:51:51 (2 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

CertDB: Cleaned up types.

Add and use the typedef sql_row.

2017-11-06 10:34:14 (2 weeks ago) by Peter Bortas <bortas@gmail.com>

Travis config: fixed maketarget name

Sunday 05 November 2017

2017-11-05 22:47:37 (2 weeks ago) by Peter Bortas <bortas@gmail.com>

Travis config: Install a pike7.8

pike8.0 is required, but this is as close as we can get with travis
Ubuntu 14 environment. Revisit this when travis-ci offers 16.04.

2017-11-05 20:51:38 (2 weeks ago) by Marcus Comstedt <marcus@mc.pp.se>

ARM64: Enable disassembler even without PIKE_DEBUG

2017-11-05 19:37:32 (2 weeks ago) by Marcus Comstedt <marcus@mc.pp.se>

ARM64: Optimize arm64_mark by using postincrement

2017-11-05 17:35:59 (2 weeks ago) by Martin Nilsson <nilsson@fastmail.com>

Test destroy compat.

2017-11-05 16:53:18 (2 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Merge branch 'grubba/rename_lfun_destroy' into 8.1

* grubba/rename_lfun_destroy:
Modules: Fixed logts of warnings.
Testsuite: Updated for LFUN::_destruct().
Compiler: Don't complain about LFUN::destroy() in compat mode.
Fix multiple warnings.
Runtime: LFUN::destroy() has been renamed to _destruct().
Compiler: Rename LFUN::destroy() to LFUN::_destruct().

2017-11-05 16:49:10 (2 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Modules: Fixed logts of warnings.

More fall out from the LFUN::destroy ==> LFUN::_destruct rename.

2017-11-05 16:16:27 (2 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Testsuite: Updated for LFUN::_destruct().
Compiler: Don't complain about LFUN::destroy() in compat mode.

2017-11-05 16:05:39 (2 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Fix multiple warnings.

LFUN::destroy() has been renamed to _destruct().

2017-11-05 16:03:11 (2 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Runtime: LFUN::destroy() has been renamed to _destruct().

Reflect the name change on some APIs.

2017-11-05 15:35:39 (2 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Compiler: Rename LFUN::destroy() to LFUN::_destruct().

As decided at Pike Conference 2017.

2017-11-05 15:23:42 (2 weeks ago) by Tobias S. Josefowitz <tobij@tobij.de>

GL.GLSL: Fix Makefile.in, unbreak testsuite.

2017-11-05 15:14:43 (2 weeks ago) by Peter Bortas <bortas@gmail.com>

Configuration file for travis-ci.org builds

2017-11-05 14:56:03 (2 weeks ago) by Arne Goedeke <el@laramies.com>

Interpreter: fix F_MARK_*_AND_POP

Since the LOCAL_VAR macro was removed, the local variables 'pc' in these
opcodes shadowed the function parameter 'pc' which was the instruction
pointer.
Image.AVS: check for overflow better

Improved the overflow check and made coverty happy. Fixes CID 1294667

2017-11-05 13:24:32 (2 weeks ago) by Martin Nilsson <nilsson@fastmail.com>

Even less computed goto.

2017-11-05 13:22:23 (2 weeks ago) by Martin Nilsson <nilsson@fastmail.com>

Even less computed goto.

2017-11-05 13:08:17 (2 weeks ago) by Per Hedbor <ph@opera.com>

Add GL.GLSL and GL.GLSLUtil.

This was a project by Per Hedbor that he intended to prepare for
inclusion in Pike and shared as a separate repository on the pike-git
server, albeit yet in the form of an external module. We have now
performed the integration into Pike as a post_module.

2017-11-05 13:08:17 (2 weeks ago) by Tobias S. Josefowitz <tobij@tobij.de>

SDL: configure now accepts non-prefixed sdl-config script

2017-11-05 12:56:07 (2 weeks ago) by Martin Nilsson <nilsson@fastmail.com>

Remove not unused variables.

2017-11-05 12:41:03 (2 weeks ago) by Peter Bortas <bortas@gmail.com>

GLUE.Driver.SDL->set_resolution(): tighten up types

2017-11-05 10:37:48 (2 weeks ago) by Arne Goedeke <el@laramies.com>

Interpreter: remove LOCAL_VAR macro

Ancient versions of gcc could not optimize short-lived local variables
very well and would instead allocate lots of stack space for them. The
interpreter function would then sometimes trigger crashes because the
stack frame got too big. These days making variables short-lived is
benefitial for the generated code. It also makes the code simpler.

Saturday 04 November 2017

2017-11-04 19:05:38 (2 weeks ago) by Arne Goedeke <el@laramies.com>

replace(): code cleanup

Make coverty happy. Fixes CID 742518.

2017-11-04 17:11:33 (2 weeks ago) by Arne Goedeke <el@laramies.com>

Build: remove TenDRA leftovers

TenDRA support was removed long ago but some defines survived.

2017-11-04 16:42:14 (2 weeks ago) by Arne Goedeke <el@laramies.com>

Remove computed goto interpreter mode

By descision of the Pike conference, computed goto mode was removed.

2017-11-04 15:51:06 (2 weeks ago) by Arne Goedeke <el@laramies.com>

Remove !SHARED_NODES

Pike with SHARED_NODES disabled did not work. By descision of the Pike
Conference it is removed.

2017-11-04 14:02:35 (2 weeks ago) by Marcus Comstedt <marcus@mc.pp.se>

Build: Disable unaligned access on arm32

When building in a 32-bit chroot on Arch Linux on arm64, the GCC
define __ARM_FEATURE_UNALIGNED is set to 1 even though unaligned
accesses are not supported in 32 bit mode. Add a test on __arch64__
as well to prevent issues.

2017-11-04 12:43:42 (2 weeks ago) by Marcus Comstedt <marcus@mc.pp.se>

ARM32: add missing label

This fixes 5 testsuite failures.

2017-11-04 09:25:01 (2 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Stdio.Terminfo: Fixed prototype for _sprintf() LFUN.

Friday 03 November 2017

2017-11-03 17:38:36 (3 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Errors: Pedantic fix.

2017-11-03 16:39:55 (3 weeks ago) by Martin Karlgren <marty@roxen.com>

FS Proxy: Allow multiple instances.
FS Proxy: Allow multiple instances.

2017-11-03 14:21:48 (3 weeks ago) by Peter Bortas <bortas@gmail.com>

release number bumped to 8.0.509 by export.pike
release number bumped to 8.0.508 by export.pike

2017-11-03 14:21:21 (3 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Pike 8.0.498 has been released as Pike 8.0 stable release 11.

2017-11-03 14:14:14 (3 weeks ago) by Peter Bortas <bortas@gmail.com>

CHANGES: Made new header for release 12 and moved some CHANGES done since build 498 to it.

2017-11-03 12:12:46 (3 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Merge branch 'patches/ws85' into devel

* patches/ws85:
CertDB: Improved diagnostics.
StartTLSProtocol: Improved rendering of certificate selector.
Variable.MultipleChoice: Added render_element().
Init: Refresh all PEM files at start.
CertDB: Added refresh_all_pem_files().
CertDB: Update the PEM file metadata.
CertDB: Add names to the keypairs.
ConfigIF: Added ACME task.
StartTLSProtocol: Use the CertDB.
StartTLSProtocol: Removed some Pike 7.8 compat.
CertDB: New module.
SSL/TLS: Add registry for certificates.
CertDB: Improved diagnostics.
StartTLSProtocol: Improved rendering of certificate selector.
Variable.MultipleChoice: Added render_element().

Simplify customizing the multiple choice variables.
Init: Refresh all PEM files at start.
CertDB: Added refresh_all_pem_files().
CertDB: Update the PEM file metadata.
CertDB: Add names to the keypairs.
ConfigIF: Added ACME task.

Present some of the info from ACMEDB.

Fixes some of [WS-66]/[WS-13].
StartTLSProtocol: Use the CertDB.
StartTLSProtocol: Removed some Pike 7.8 compat.
CertDB: New module.

Provide an API to access the SSL/TLS Certificate registry.

Fixes some of [WS-66]/[WS-85].

2017-11-03 11:27:49 (3 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

SSL/TLS: Add registry for certificates.

Adds some DB tables for keeping track of certificates.

Fixes some of [WS-66]/[WS-85].

Thursday 02 November 2017

2017-11-02 19:18:12 (3 weeks ago) by Martin Nilsson <nilsson@fastmail.com>

Fixed some cppclean complaints

2017-11-02 16:42:40 (3 weeks ago) by Stephen R. van den Berg <srb@cuci.nl>

CHANGES updated.

2017-11-02 16:35:51 (3 weeks ago) by Stephen R. van den Berg <srb@cuci.nl>

HTTP.Query: Support skipping chunked options.
HTTP.Query: timed_async_fetch() failed to skip the header.

2017-11-02 16:31:27 (3 weeks ago) by Stephen R. van den Berg <srb@cuci.nl>

HTTP.Query: Support skipping chunked options.
HTTP.Query: timed_async_fetch() failed to skip the header.
HTTP.Promise: async_data() dropped 'slow' data.

2017-11-02 15:44:23 (3 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Testsuite: Added test of __ARGS__.

Wednesday 01 November 2017

2017-11-01 17:36:59 (3 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Stdio.Buffer: Some type and documentation updates.

2017-11-01 16:43:47 (3 weeks ago) by Arne Goedeke <el@laramies.com>

Stdio.Buffer()->trim(): fixed possible memcpy on overlapping regions

trim() will move data inside of the buffer regardless of the number
of wasted bytes. In those cases src and dst of the memcpy() call may
overlap.

2017-11-01 16:40:16 (3 weeks ago) by Arne Goedeke <el@laramies.com>

Stdio.Buffer()->trim(): fixed possible memcpy on overlapping regions

trim() will move data inside of the buffer regardless of the number
of wasted bytes. In those cases src and dst of the memcpy() call may
overlap.

2017-11-01 14:53:30 (3 weeks ago) by Stephen R. van den Berg <srb@cuci.nl>

time: Clarify and correct documentation.
pgsql: Suppress 'File not open' output on stderr for query_fd().

2017-11-01 14:50:36 (3 weeks ago) by Stephen R. van den Berg <srb@cuci.nl>

time: Clarify and correct documentation.

2017-11-01 12:18:29 (3 weeks ago) by Arne Goedeke <el@laramies.com>

Stdio.Buffer: fixed growth strategy

Unless trim() was called manually or unless the buffer was empty,
the growth strategy would never reuse empty space at the beginning
of the buffer. Instead, it would always allocate more space.

The code now works as described in the comment. When at least half of
the buffer space in the beginning of the allocated region is unused,
the data is moved to the front before new memory is being allocated.
push_*: handle possible evaluation errors

Always evaluate the macro arguments before incrementing the stack
pointer.
push_string(): handle OOM errors correctly

make_shared_string() may throw an error in OOM situation. If that
happens here, we will end up having a corrupt svalue on the stack.

2017-11-01 12:16:18 (3 weeks ago) by Arne Goedeke <el@laramies.com>

Interpreter: set 'pc' to zero

The tracing code is using this to decide if we are currently calling a
pike function or not.

2017-11-01 11:59:33 (3 weeks ago) by Arne Goedeke <el@laramies.com>

Stdio.Buffer: fixed growth strategy

Unless trim() was called manually or unless the buffer was empty,
the growth strategy would never reuse empty space at the beginning
of the buffer. Instead, it would always allocate more space.

The code now works as described in the comment. When at least half of
the buffer space in the beginning of the allocated region is unused,
the data is moved to the front before new memory is being allocated.
push_*: handle possible evaluation errors

Always evaluate the macro arguments before incrementing the stack
pointer.
push_string(): handle OOM errors correctly

make_shared_string() may throw an error in OOM situation. If that
happens here, we will end up having a corrupt svalue on the stack.

2017-11-01 11:41:52 (3 weeks ago) by Arne Goedeke <el@laramies.com>

Compiler: convert some macros to inline functions

Makes things more readable.

Tuesday 31 October 2017

2017-10-31 15:22:29 (3 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Merge branch 'feature/CMS-297-secure-sitebuilder-cookie' into 6.1

* feature/CMS-297-secure-sitebuilder-cookie:
Fixed NPE in RequestID->client_scheme() [CMS-297]
Refactoring after QA feedback. [CMS-297]

2017-10-31 14:44:32 (3 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Crypto.CCM: Fixed initialization of the iv.

The initialization of the CCM iv lacked one level of indirection,
and instead zapped the iv string fields (including the flags field),
which caused free_string() to later unlink the unshared iv string
from the string hash table, which in turn triggered a fatal.

2017-10-31 14:41:06 (3 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Crypto.CCM: Fixed initialization of the iv.

The initialization of the CCM iv lacked one level of indirection,
and instead zapped the iv string fields (including the flags field),
which caused free_string() to later unlink the unshared iv string
from the string hash table, which in turn triggered a fatal.

2017-10-31 10:52:34 (3 weeks ago) by Stephen R. van den Berg <srb@cuci.nl>

Crypto.Checksum: Update docs.

2017-10-31 00:05:26 (3 weeks ago) by Stephen R. van den Berg <srb@cuci.nl>

crc32c: Add optional seed to chain invocations.
Arg: Simplify code.
MIME: Support trailing \n epilogues on MIME parts.
pgsql: Suppress 'File not open' output on stderr for query_fd().

Monday 30 October 2017

2017-10-30 15:57:19 (3 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Merge branch 'patches/ws52' into 6.1

* patches/ws52:
DB-browser: Nicer color for tables without backup
DB-browser: Improved layout of existing backups table
DB-browser: Show full path to backups again
DB-browser: Removed extranous String.capitalize().
DB-browser: Improved YES_I_KNOW_WHAT_I_AM_DOING.
DB-browser: Add indication that a table isn't backed up.
DBManager: Add APIs to check whether backups are inhibited.
DBManager: Inhibit backups of quite a few tables in the local db.
DBManager: Added support to exclude some tables from backup.
DBManager: delete_backup() now knows about partial backups.
DB-browser: Indicate incomplete backups.
DBManager: Keep track of backups in progress.

2017-10-30 15:55:32 (3 weeks ago) by Anders Johansson <anders@roxen.com>

DB-browser: Nicer color for tables without backup
DB-browser: Improved layout of existing backups table
DB-browser: Show full path to backups again

They are essential when using manual directory names.

2017-10-30 15:50:40 (3 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Merge branch 'feature/CMS-297-secure-sitebuilder-cookie' into 6.1

* feature/CMS-297-secure-sitebuilder-cookie:
Renamed RequestID->client_prot(). [CMS-297]
New function 'client_prot()' [CMS-297]
Removed trailing spaces.

2017-10-30 11:22:46 (3 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Protocols.LDAP: Use SSL in blocking mode.

SSL.File defaults to non-blocking mode and the LDAP module
attempts syncronous blocking writes. Non-blocking mode causes
these writes to eg fail with EAGAIN if the connection hasn't
finished being negotiated before the first write.

Fixes "LDAP write error: Resource temporarily unavailable".
Protocols.LDAP: Use SSL in blocking mode.

SSL.File defaults to non-blocking mode and the LDAP module
attempts syncronous blocking writes. Non-blocking mode causes
these writes to eg fail with EAGAIN if the connection hasn't
finished being negotiated before the first write.

Fixes "LDAP write error: Resource temporarily unavailable".

Sunday 29 October 2017

2017-10-29 19:08:55 (3 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

WhiteFish.Blobs: Minor code cleanup.

Get rid of a cast by using a different function.

Also some documentation cleanup.

2017-10-29 02:07:39 (3 weeks ago) by Martin Nilsson <nilsson@fastmail.com>

Added option for Stadnards.JSON.decode to decode without decoding to object Val.true, Val.false and Val.null.

2017-10-29 01:31:03 (3 weeks ago) by Martin Nilsson <nilsson@fastmail.com>

Unify internal flags.

Saturday 28 October 2017

2017-10-28 21:56:35 (3 weeks ago) by Marcus Comstedt <marcus@mc.pp.se>

ARM64: added DUP, SWAP and NOT

2017-10-28 13:42:41 (3 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Pike.Lazy: Improved typing.

Also some documentation updates.

2017-10-28 08:55:13 (3 weeks ago) by Marcus Comstedt <marcus@mc.pp.se>

Image.PVR: Fix size check for twiddled images. Fixes [CID 1294661].
Image.PVR: Fix size check for twiddled images. Fixes [CID 1294661].

2017-10-28 08:46:00 (3 weeks ago) by Marcus Comstedt <marcus@mc.pp.se>

Image.PVR: Fix size check for twiddled images. Fixes [CID 1294661].

Friday 27 October 2017

2017-10-27 15:55:14 (4 weeks ago) by Anders Johansson <anders@roxen.com>

DB-browser: Nicer color for tables without backup

2017-10-27 14:47:41 (4 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Documentation [Standards.PEM]: Some minor clarifications.

2017-10-27 13:19:12 (4 weeks ago) by Anders Johansson <anders@roxen.com>

DB-browser: Improved layout of existing backups table

2017-10-27 12:29:48 (4 weeks ago) by Anders Johansson <anders@roxen.com>

DB-browser: Show full path to backups again

They are essential when using manual directory names.

2017-10-27 10:49:06 (4 weeks ago) by Anders Johansson <anders@roxen.com>

DBManager: Removed broken debug flag DBMANAGER_DEBUG

It was broken since 2001.

Thursday 26 October 2017

2017-10-26 15:36:31 (4 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Stdio.sendfile: Fixed double free of callback args.

The array of callback arguments would in some circumstances
get freed twice on destruct() (once by the exit callback
and once by the cleanup code for mapped variables).

Wednesday 25 October 2017

2017-10-25 15:20:46 (4 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

hashmem: Minor code cleanup.

Make Coverity happy by avoiding an intentionally unreachable
return statement.

Fixes [CID 745917].

Tuesday 24 October 2017

2017-10-24 14:04:02 (4 weeks ago) by Martin Karlgren <marty@roxen.com>

internal_tag_select: Avoid some trampoline garbage.

2017-10-24 11:14:18 (4 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

explode: Use the size_shift enum constants.

Also adds a default case to keep Coverity happy.

Fixes [CID 742524].

Monday 23 October 2017

2017-10-23 11:14:12 (4 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

ACME: Added some tentative DB table definitions.

Fixes some of [WS-66]/[WS-13].

2017-10-23 10:50:48 (4 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

encode_value: Guard some potentially dead code.

The Pike_FP_PZERO case isn't reached if not HAVE_ISZERO.

Fixes [CID 742482].

Sunday 22 October 2017

2017-10-22 19:12:45 (4 weeks ago) by Martin Nilsson <nilsson@fastmail.com>

Have the #(#), #[#], #{#} documentation show up.
Refdoc syntax fix.

2017-10-22 13:28:09 (4 weeks ago) by Arne Goedeke <el@laramies.com>

Interpreter: set 'pc' to zero

The tracing code is using this to decide if we are currently calling a
pike function or not.

2017-10-22 12:00:30 (4 weeks ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Gc: Some more minor code-cleanups.

Make pointer adjustment more explicit in remaining places.

Fixes [CID 742447] some more.

Saturday 21 October 2017

2017-10-21 13:24:00 (1 month ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Gc: Minor code-cleanup.

Make a pointer adjustment more explicit.

Fixes [CID 742447].

Friday 20 October 2017

2017-10-20 15:24:59 (1 month ago) by William Welliver <william@welliver.org>

Image.SVG: fall back to pkg-config if one for the current arch isn't present.

2017-10-20 13:45:37 (1 month ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Merge branch 'patches/bug7834' into 6.1

* patches/bug7834:
UserFS: Support users with new-style MySQL password hashes.

2017-10-20 13:43:02 (1 month ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Merge branch 'patches/bug7834' into devel

* patches/bug7834:
UserFS: Support users with new-style MySQL password hashes.

2017-10-20 13:37:49 (1 month ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

UserFS: Support users with new-style MySQL password hashes.

MySQL 4.1 and later prefix hashes from their internal
password hashing function with a single "*".

Thanks to Eiichiro ITANI <emu@@ceres.dti.ne.jp> for the report.

Fixes [bug 7834].

2017-10-20 11:57:38 (1 month ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

HTTPLoop: Make array property of sentinel more explicit.

Make Coverity happy.

Fixes [CID 742368].

2017-10-20 02:48:21 (1 month ago) by William Welliver <william@welliver.org>

Image.SVG: fall back to pkg-config if one for the current arch isn't present.

Thursday 19 October 2017

2017-10-19 16:54:46 (1 month ago) by Anders Johansson <anders@roxen.com>

ImageCache: Updated available image format documentation

2017-10-19 15:16:10 (1 month ago) by Anders Johansson <anders@roxen.com>

Search.Utils: Updated debug string format.

Synced with Roxen 6.1.

2017-10-19 15:12:24 (1 month ago) by Anders Johansson <anders@roxen.com>

Search.Utils: Updated debug string format.

Synced with Roxen 6.1.

2017-10-19 14:50:51 (1 month ago) by Pontus Östlund <ponost@roxen.com>

Added the initial work on ACME.

2017-10-19 13:58:18 (1 month ago) by Anders Johansson <anders@roxen.com>

ImageCache: Added support for WebP as output format

Usable with format="webp" in <cimg/> and friends.

2017-10-19 10:50:21 (1 month ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Builtin: Added some braces.

Make Coverity happy.

Fixes [CID 1294648].

Wednesday 18 October 2017

2017-10-18 19:59:48 (1 month ago) by Pontus Östlund <ponost@roxen.com>

Some style stuff.

2017-10-18 19:57:24 (1 month ago) by Pontus Östlund <ponost@roxen.com>

Begun a hotkey (like in Sitebuilder) so you can specify which button should react to which keyboard key.

Not done yet.

2017-10-18 19:55:18 (1 month ago) by Pontus Östlund <ponost@roxen.com>

Wizard seems to work.

Updated the cert genration wizards. They seem to work.

2017-10-18 15:54:18 (1 month ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Mappings: Disable hash bucket propagation.

Fixes [CID 742748].

2017-10-18 15:05:34 (1 month ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Merge branch 'patches/ws52' into devel

* patches/ws52:
DB-browser: Removed extranous String.capitalize().
DB-browser: Improved YES_I_KNOW_WHAT_I_AM_DOING.
DB-browser: Add indication that a table isn't backed up.
DBManager: Add APIs to check whether backups are inhibited.
DBManager: Inhibit backups of quite a few tables in the local db.
DBManager: Added support to exclude some tables from backup.
DBManager: delete_backup() now knows about partial backups.
DB-browser: Indicate incomplete backups.
DBManager: Keep track of backups in progress.
DB-browser: Removed extranous String.capitalize().
DB-browser: Improved YES_I_KNOW_WHAT_I_AM_DOING.
DB-browser: Add indication that a table isn't backed up.

Fixes some of [WS-52]/[WS-80].
DBManager: Add APIs to check whether backups are inhibited.

module_table_info() now indicates whether the selected table
is backed up or not.

Also adds documentation for module_table_info().
DBManager: Inhibit backups of quite a few tables in the local db.

Inhibits backup of tables for:

* The argument cache.

* The image caches.

* The compiled log formats cache.

* The cache of available modules.

* The precompiled files cache.

* The session cache.

This should cause backups of the local db to complete much faster.

Fixes some of [WS-52].
DBManager: Added support to exclude some tables from backup.

Adds inhibit_backups() and permit_backups().

Fixes some of [WS-52]/[WS-80].

2017-10-18 11:16:59 (1 month ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

DBManager: delete_backup() now knows about partial backups.

Fixes some more of [WS-52]/[WS-79].

Tuesday 17 October 2017

2017-10-17 17:47:59 (1 month ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

DB-browser: Indicate incomplete backups.

The DB-browser now knows of the entry in db_backups that indicates
that a backup is in progress, and marks such backups as incomplete
in the interface.

Fixes some of [WS-52].

2017-10-17 17:39:03 (1 month ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

DBManager: Keep track of backups in progress.

Backups in progress now have a temporary entry in the
db_backups table (indicated as a backup of the table "").
The temporary entry is replaced by entries for the
individual tables when the backup completes.

This means that we no longer lose track of backups that are
in progress when the server restarts.

Fixes some of [WS-52].

2017-10-17 14:06:26 (1 month ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

replace: Added some paranoia.

Complain if the size_shift is invalid.

Fixes [CID 742549].

2017-10-17 12:33:44 (1 month ago) by Pontus Östlund <ponost@roxen.com>

Added some helper methods to Crypto.

string md5(string data, void|bool raw)
string sha1(string data, void|bool raw)
string sha256(string data, void|bool raw)

These methods return a hexadecimal string unless `raw` is given. These methods are composed via the helper method `hash()`.

string hmac_md5(string secret, string data)
string hmac_sha1(string secret, string data)
string hmac_sha256(string secret, string data)

These methods return a hexadecimal string. These methods are composed via the helper method `hash_hmac()` which can be used to construct new hmac hashing functions.

2017-10-17 09:24:59 (1 month ago) by Pontus Östlund <ponost@roxen.com>

Added the initial work on ACME.

2017-10-17 08:11:23 (1 month ago) by Tobias Liin <liin@roxen.com>

release number bumped to 8.0.507 by export.pike
release number bumped to 8.0.506 by export.pike

2017-10-17 08:07:14 (1 month ago) by Pontus Östlund <ponost@roxen.com>

Style fixes according to the last pike additions/changes.
Changed the order of grouped defvars.

Defvars without group is displayed first, then the groups and lastly the "Module Priority" defvar.
Just a whitespace change.

2017-10-17 08:02:22 (1 month ago) by Pontus Östlund <ponost@roxen.com>

Removed some redundant HTML attributes and added a css class to Variable.Mapping.

2017-10-17 08:02:04 (1 month ago) by Tobias Liin <liin@roxen.com>

Version bumped to 6.2.62 by buildsystem.

2017-10-17 08:01:25 (1 month ago) by Pontus Östlund <ponost@roxen.com>

Pikedoc fixes to Mustache.
Fixed the HTML of some of the cert generating stuff.

2017-10-17 07:58:02 (1 month ago) by Pontus Östlund <ponost@roxen.com>

Had missed adding the saved state to the form.

Monday 16 October 2017

2017-10-16 12:54:45 (1 month ago) by Karl Gustav Sterneberg <kg@roxen.com>

Merge branch 'feature/CMS-297-secure-sitebuilder-cookie' into devel

2017-10-16 12:48:26 (1 month ago) by Karl Gustav Sterneberg <kg@roxen.com>

Fixed NPE in RequestID->client_scheme() [CMS-297]

2017-10-16 10:59:49 (1 month ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Mappings: Use sub_ref() when we know that we have extra refs.

Fixes some more of [CID 742747] and [CID 742750].

2017-10-16 10:49:36 (1 month ago) by Karl Gustav Sterneberg <kg@roxen.com>

Added attribute link-rel='' to <wash-html>.

[WS-47]
* 775724c - Added attribute link-rel='' to <wash-html>. <Tobias Liin>
* 35d6f01 - Changed from '' to "" in tagdoc for coherency with the
existing doc. <Tobias Liin>
* 71938a5 - Replaced ' with " in href attribute when linkifying.
<Tobias Liin>

2017-10-16 09:00:38 (1 month ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Build [Whitefish]: Use the standard VPATH.

Don't add the root source directory the VPATH as it causes eg buffer.o
in the root source directory to inhibit building Whitefish's buffer.o.

Potential fix for building issues on NT.

Sunday 15 October 2017

2017-10-15 12:29:37 (1 month ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Mappings: Use sub_ref() when we know that we have extra refs.

Fixes [CID 742747] and [CID 742750].

Saturday 14 October 2017

2017-10-14 12:18:44 (1 month ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

size_object(): Added some assertions.

Make Coverity happy...

Fixes [CID 1294650].

2017-10-14 02:54:15 (1 month ago) by William Welliver <william@welliver.org>

smartlink: NetBSD uses the Darwin convention for rpath.
smartlink: shift past -L arguments so that they aren't duplicated on the outgoing command-line.
smartlink: support Darwin-style rpath
smartlink: update the shell version of smartlink to include Darwin rpath

2017-10-14 02:51:25 (1 month ago) by William Welliver <william@welliver.org>

smartlink: update the shell version of smartlink to include Darwin rpath
smartlink: NetBSD uses the Darwin convention for rpath.

Friday 13 October 2017

2017-10-13 20:33:06 (1 month ago) by Chris Angelico <rosuav@gmail.com>

Support precompilation with Pike 8.1

2017-10-13 15:17:09 (1 month ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Merge branch 'patches/image-cache' into 5.5

* patches/image-cache:
Image-Cache: Added some more ARG_CACHE_DEBUG.
Image-Cache: Reverted some of 99a96a3d11.
Merge branch 'patches/image-cache' into 6.0

* patches/image-cache:
Image-Cache: Added some more ARG_CACHE_DEBUG.
Image-Cache: Reverted some of 99a96a3d11.
Merge branch 'patches/image-cache' into 6.1

* patches/image-cache:
Image-Cache: Added some more ARG_CACHE_DEBUG.
Image-Cache: Reverted some of 99a96a3d11.

2017-10-13 15:14:13 (1 month ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Merge branch 'patches/image-cache' into devel

* patches/image-cache:
Image-Cache: Added some more ARG_CACHE_DEBUG.
Image-Cache: Reverted some of 99a96a3d11.
Image-Cache: Added some more ARG_CACHE_DEBUG.
Image-Cache: Reverted some of 99a96a3d11.

This catch caused <emit#cimg/> to perform sizeof() on zero,
triggering a 500-error.

Fixes [WS-77].

2017-10-13 14:02:58 (1 month ago) by Karl Gustav Sterneberg <kg@roxen.com>

Refactoring after QA feedback. [CMS-297]

2017-10-13 13:04:38 (1 month ago) by Karl Gustav Sterneberg <kg@roxen.com>

Custom Headers Filter Module. [WS-63]

Adjustments after QA.

2017-10-13 12:23:05 (1 month ago) by Chris Angelico <rosuav@gmail.com>

Add history pop function to Readline for Hilfe's benefit
Hilfe: Show documentation for programs
Per TODO, suppress quit/exit from history
Hilfe: Add the beginnings of a help() function
Hilfe: Show help documentation for functions
Hilfe: Show help info for more types
Fix typo in CHANGES

2017-10-13 11:18:30 (1 month ago) by Chris Angelico <rosuav@gmail.com>

Hilfe: Show help info for more types

2017-10-13 11:12:44 (1 month ago) by Chris Angelico <rosuav@gmail.com>

Hilfe: Show documentation for programs
Hilfe: Show help documentation for functions

2017-10-13 10:59:11 (1 month ago) by Chris Angelico <rosuav@gmail.com>

Hilfe: Add the beginnings of a help() function

2017-10-13 10:51:12 (1 month ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

Runtime: Added assertion to make Coverity happy.

Fixes [CID 742539].

2017-10-13 10:30:02 (1 month ago) by Chris Angelico <rosuav@gmail.com>

Per TODO, suppress quit/exit from history

2017-10-13 10:26:34 (1 month ago) by Chris Angelico <rosuav@gmail.com>

Add history pop function to Readline for Hilfe's benefit

Thursday 12 October 2017

2017-10-12 20:39:36 (1 month ago) by Pontus Östlund <ponost@roxen.com>

Started the "light" variant of the new CFIF, and removed all the old incompatible themes.
Begun implementation of the new wizard (not done yet).

2017-10-12 20:36:21 (1 month ago) by Pontus Östlund <ponost@roxen.com>

Additions for groupable defvars and the wizard.

2017-10-12 20:25:23 (1 month ago) by Pontus Östlund <ponost@roxen.com>

Implemented groupable defvars.

Variable.Variable:

* Added the member `__group` with corresponding getter `LocaleString group()` and setter `this_program set_group(LocaleString name)`.

* Also changed all `void` to return the object being called to enable chained calls.

defvar("myvar", Variable.Variable(...))
->set_invisibility_callback(cb)
->set_group("My Group");

Config tags:

* emit#module-variables checks if any groups are defined in the variable list, and if so group those together. If an item is a group the mapping will contain the members `is-group`, `group (the name of the group)` and `vars (the list of variables in the group)`.

CFIF/template:

* The tag definition `<cfg-variables>` handles the emission of grouped defvars.

2017-10-12 20:21:25 (1 month ago) by Pontus Östlund <ponost@roxen.com>

Added the variable attribute to <scope>.

The purpose of this is to be able to extract a variable wich is a mapping into its own scope.

2017-10-12 20:08:27 (1 month ago) by Pontus Östlund <ponost@roxen.com>

Added .svg files to permission check exclusions.

2017-10-12 13:23:39 (1 month ago) by Karl Gustav Sterneberg <kg@roxen.com>

Removed trailing spaces.
New function 'client_prot()' [CMS-297]

Added new function 'client_prot()', returns the original client
protocol name.
Renamed RequestID->client_prot(). [CMS-297]

Renamed RequestID->client_prot() in prototypes.pike to
client_scheme().

2017-10-12 11:37:06 (1 month ago) by Karl Gustav Sterneberg <kg@roxen.com>

Custom Headers Filter Module. [WS-63]

2017-10-12 10:11:41 (1 month ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

HTTPLoop: Improved concurrency of log_as_array() and log_size().

Release the interpeter lock before locking the log_lock.
Image.Image: Improved argument checking in apply_curve().

Non-integer array values lead to use of uninitialized curve values.

Fixes [CID 1400857].
HTTPLoop: Get the log_lock before messing with log_head.

Fixes unlikely race in cleanup code on accept(2) failing with EBADF.

Fixes [CID 742665].

2017-10-12 10:01:50 (1 month ago) by Henrik Grubbström (Grubba) <grubba@grubba.org>

HTTPLoop: Improved concurrency of log_as_array() and log_size().

Release the interpeter lock before locking the log_lock.
HTTPLoop: Get the log_lock before messing with log_head.

Fixes unlikely race in cleanup code on accept(2) failing with EBADF.

Fixes [CID 742665].

2017-10-12 07:54:03 (1 month ago) by Arne Goedeke <el@laramies.com>

ARM32: added DUP, SWAP and NOT

[permalink]

Bugs mentioned

  2001RESOLVEDBacktrace when changing prototcol from http to https
  2017RESOLVEDFailed to decode "favicon.ico"
  7834RESOLVEDuserdb_sql with "password_type" == "password", will not work with userfs
Bugs? Suggestions?