Branch: Tag:

2017-09-02

2017-09-02 09:48:13 by Henrik Grubbström (Grubba) <grubba@grubba.org>

Mysql.result: Renamed seek() to low_seek().

This function performs absolute positioning (rather than the
relative positioning of __builtin.Sql.Result()->seek()), and
was shadowed by a generic (relative) implementation in previous
versions of Pike.

CAVEAT: Old code that used sql_res->master_res->seek() will
break and need to be updated. Any such code will trigger
warnings as master_res has been declared deprecated.
It is also unlikely that any such code exists, since the
function didn't comply with its documented behavior.

Fixes some testsuite failures.

491:    "id_manager": "predef::Protocols.X.Xlib.Display":1,    "idenfier": "predef::Program.defined":1,    "idenfifier": "predef::Program.defined":1, +  "index": "predef::Mysql.mysql.Result.low_seek":1,    "inhibi_errors": "predef::Tools.Testsuite.Test.compile":1,    "int ": "predef::Calendar.Time.SuperTimeRange.second":3, "predef::Calendar.Time.TimeofDay.hour":1, "predef::Calendar.Time.TimeofDay.hour_no":3, "predef::Calendar.Time.TimeofDay.minute":1, "predef::Calendar.Time.TimeofDay.second":1, "predef::Calendar.Time.TimeofDay.unix_time":1, "predef::Calendar.TimeRanges.TimeRange.`/":2, "predef::Calendar.TimeRanges.TimeRange.offset_to":1, "predef::Calendar.YMD.YMD.fraction_no":13, "predef::Calendar.YMD.YMD.number_of_days":1, "predef::Calendar.YMD.YMD.second":3, "predef::Image.Color.Color.`==":4, "predef::Image.Color.Color.bits":1, "predef::Image.Color.Color.rgb":2, "predef::Image.Image.`==":9, "predef::Image.Image.gradients":2, "predef::Image.Image.xsize":1, "predef::Image.Image.ysize":1, "predef::Image.Layer.set_offset":2, "predef::Image.Layer.set_tiled":1, "predef::Image.Layer.xsize":2,    "key": "predef::Web.Auth.OAuth.Client.set_token":1,
556:    "search_order": "predef::Search.Query.execute":1,    "second.datetime": "predef::Calendar.YMD.datetime":1,    "seek": "7.8::Stdio.FILE.line_iterator":1, +  "seek()": "predef::Mysql.mysql.Result.fetch_row":1, "predef::Mysql.mysql.Result.low_seek":2,    "send_reply()": "predef::Protocols.DNS.server_base.handle_query":1,    "set_backend": "7.8::Stdio.File.set_read_callback":2,    "set_buffer_mode": "predef::Stdio":2,
1268:   "predef::Mysql.SqlTable.select": "Sql.big_typed_query"   "predef::Mysql.mysql.Result.create": "Mysql.mysql_result"   "predef::Mysql.mysql.Result.fetch_json_result": "set_unicode_decode_mode" + "predef::Mysql.mysql.Result.fetch_row": "seek()" + "predef::Mysql.mysql.Result.low_seek": "index" "seek()"   "predef::Mysql.mysql.create": "set_charset" "set_unicode_decode_mode"   "predef::NetUtils.NetMask.ip_in": "bool"   "predef::NetUtils.get_network_type": "bool"