pike.git/ src/ builtin_functions.c

2020-08-14

2020-08-14 09:36:26 by Henrik Grubbström (Grubba) <grubba@grubba.org>

• f25affffe69e6ab7a9d26ef36743e8ee037aacca (36 lines) (+19/-17) ^{[ Show | Annotate ]}
  Branch: master

EFUNs: Do not throw errors on validation failure in crypt().

The glibc crypt() implementation in RHEL 8 apparently sometimes
performs misguided "validation" of the salt even for "$6$" and
fails with EINVAL instead of actually validating the password.

Throwing an error on validation failure is not what existing
code expects, so just return a failure instead in this case.

Fixes some of #10050.

See also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=714219

3664:   #error No crypt function found and fallback failed.   #endif    +  if(args < 2) +  {    if (!ret) {    switch(errno) {   #ifdef ELIBACC
3681:    break;    }    } -  if(args < 2) -  { +     pop_n_elems(args);    push_text(ret);    }else{    int i; -  i=!strcmp(ret,saltp); +  i = ret && !strcmp(ret,saltp);    pop_n_elems(args);    push_int(i);    }