Branch: Tag:

2018-11-28

2018-11-28 20:33:22 by Tobias S. Josefowitz <tobij@tobij.de>

Interpreter: Avoid branching on partially uninitialised memory

(Likely) no harm coming from this, as presumably even "partially
defined" cases cannnot not be equal to -1, but this helps to keep
valgrind quiet.

2188:    struct pike_frame *new_frame = NULL;       int type = (function->identifier_flags & (IDENTIFIER_TYPE_MASK|IDENTIFIER_ALIAS)); -  if( o->prog != pike_trampoline_program && function->func.offset != -1 ) +  if( o->prog != pike_trampoline_program && +  !( + #ifdef USE_VALGRIND +  type & IDENTIFIER_PIKE_FUNCTION && + #endif +  function->func.offset == -1 ))    {    switch( type )    {