pike.git/ src/ las.cmod

2021-11-16

2021-11-16 12:34:46 by Henrik Grubbström (Grubba) <grubba@grubba.org>

• d48294740ec477231a12cac77955fcb7bc7fbaf2 (25 lines) (+23/-2) ^{[ Show | Annotate ]}
  Branch: master

Compiler [Typechecker]: Improved zero handling in check_node_type().

Fixes several issues where nullable types match only for zero.

450:    /* print_tree(n); */    return 0;    } +  if (n->type != zero_type_string) { +  /* Report if the only match was for zero. */ +  struct pike_type *diff2 = +  type_binop(PT_BINOP_MINUS, n->type, zero_type_string, 0, 0, 0); +  if (l_flag > 10) { +  fprintf(stderr, "diff2 = "); +  simple_describe_type(diff2); +  fprintf(stderr, "\n"); +  } +  if (diff == diff2) { +  /* Mismatch for everything but zero. */ +  yytype_report(REPORT_ERROR, NULL, 0, t, NULL, 0, diff, 0, msg); +  free_type(diff2); +  free_type(diff); +  /* print_tree(n); */ +  return 0; +  } +  free_type(diff2); +     if (THIS_COMPILATION->lex.pragmas & ID_STRICT_TYPES) {    yytype_report(REPORT_WARNING, NULL, 0, t, NULL, 0, diff, 0, msg);    } -  +  }    free_type(diff);   #else    if (pike_types_le(n->type, t, 0, 0)) return 1;