2014-05-22 16:49:17 by Per Hedbor <firstname.lastname@example.org>
Binary size: push_constant_text -> push_text when not time-critical.
Especially in error handling, and code that does a lot of other string
operations anyway the speed gain is not wort the 100+ bytes code size
of each instance of push_constant_text
This saves about 20K of code size (main pike binary), while not really
changing the speed much.
push_constant_text that seemed to be in at least pseudo-time-critical
code was kept as they were.
On a related note, push_constant_text(":") four times in a row creates
four different string variables, for obvious reasons.
Some of the remaining push_constant_text really should have a
module/file local string variable, even though that is more bothersome
It might be nice to have this in .cmod files automatically.
Inside #if defined(HAVE_GRANTPT) || defined(USE_PT_CHMOD) || defined(USE_CHGPT)
Inside #if !defined(__NT__) && (defined(HAVE_POSIX_OPENPT) || defined(PTY_MASTER_PATHNAME))
Inside #if defined(HAVE_LINUX_IF_H) && defined(HAVE_SYS_IOCTL_H)