pike.git/ src/ operators.c

2014-12-04

2014-12-04 19:25:23 by Per Hedbor <ph@opera.com>

• 462b980e9ba052a7cd5ccc969e03aa356991b1b8 (15 lines) (+7/-8) ^{[ Show | Annotate ]}
  Branch: bill/master_archive_support

Nano-optimization: Do not call strlen twice

This optimizes string += int and string += float minimally.
It is probably not even detectable.

1598:    struct pike_string *r;    PCHARP buf;    char buffer[MAX_NUM_BUF]; -  int max_shift=0; +  int max_shift=0, len;       if ((TYPEOF(sp[-args]) != T_STRING) && (TYPEOF(sp[1-args]) != T_STRING)) {    struct svalue *save_sp = sp;
1693:   #endif       append_buffer: +  len = strlen(buffer);    switch(max_shift)    {    case 0: -  convert_0_to_0((p_wchar0 *)buf.ptr,buffer,strlen(buffer)); +  convert_0_to_0((p_wchar0 *)buf.ptr,buffer,len);    break;       case 1: -  convert_0_to_1((p_wchar1 *)buf.ptr,(p_wchar0 *)buffer, -  strlen(buffer)); +  convert_0_to_1((p_wchar1 *)buf.ptr,(p_wchar0 *)buffer,len);    break;       case 2: -  convert_0_to_2((p_wchar2 *)buf.ptr,(p_wchar0 *)buffer, -  strlen(buffer)); +  convert_0_to_2((p_wchar2 *)buf.ptr,(p_wchar0 *)buffer,len);    break; -  +     } -  INC_PCHARP(buf,strlen(buffer)); +  INC_PCHARP(buf,len);    }    }    r = realloc_unlinked_string(r, SUBTRACT_PCHARP(buf, MKPCHARP_STR(r)));