Branch: Tag:

2008-01-29

2008-01-29 12:17:26 by Per Hedbor <ph@opera.com>

Leak somewhat less. However, I'm not 100% certain that push_pgdk2object is correctly used in all places where it's used.

Rev: src/post_modules/GTK2/source/support.c:1.19

2:   || This file is part of Pike. For copyright information see COPYRIGHT.   || Pike is distributed under GPL, LGPL and MPL. See the file COPYING   || for more information. - || $Id: support.c,v 1.18 2008/01/23 04:27:46 per Exp $ + || $Id: support.c,v 1.19 2008/01/29 12:17:26 per Exp $   */      #include <version.h>
270:    call_c_initializers(o);    ((struct object_wrapper *)o->storage)->obj=obj;    pgtk2__init_object(o); -  ref_push_object(o); +  +  /* Extra ref already added in pgtk2__init_object */ +  push_object(o);    return;   }   
284:    o=low_clone(def);    call_c_initializers(o);    ((struct object_wrapper *)o->storage)->obj=obj; -  ref_push_object(o); +  +  /* TODO: Check all usage of this function to see that it does not +  * assume 2 refs on the object instead of 1. +  */ +  push_object(o);    return;   }