pike.git/ src/ stralloc.c

2014-12-04

2014-12-04 19:23:10 by Henrik Grubbström (Grubba) <grubba@grubba.org>

• 664ac4e36ba551bd873d3fa6e7212bbbcbfca4a5 (9 lines) (+6/-3) ^{[ Show | Annotate ]}
  Branch: bill/master_archive_support

Fixed padding bug in string_builder_append_integer().

It would add erroneous left padding if the field was full.

eg string_builder_append_integer(&s, 16, 10, APPEND_SIGNED, 2, 0)
would append the string "16 " instead of the expected "16".

This bug also affected string_builder_sprintf().

2745:    if (len < precision) len = precision;       /* Perform padding. */ -  if ((len < min_width) && !(flags & APPEND_LEFT)) { +  if (!(flags & APPEND_LEFT)) { +  if (len < min_width) {    string_builder_fill(s, min_width - len, MKPCHARP(" ", 0),    4, 0); -  +  }    min_width = 0;    }