pike.git/ src/ testsuite.in

2018-05-24

2018-05-24 14:37:42 by Henrik Grubbström (Grubba) <grubba@grubba.org>

• e882dd6def125cabc6b1523520dbb35e85d6ab69 (28 lines) (+28/-0) ^{[ Show | Annotate ]}
  Branch: 8.0

Pike.identify_cycle: Fix various issues with LFUNs throwing errors.

LFUNs used by mapping operations may throw errors; this caused
identify_loop_visit_leave() to also throw errors. The rest of
the identify_cycle code was not happy about this and

* Forgot to unlock the mc_mutex. This caused all following calls
to Pike.identify_cycle() and Pike.count_memory() to hang.

* Leaked memory.

The above issues are now avoided by instead using the addresses
of objects as indices in the affected mapping. It also fixes
the issue with hangs if there are objects with lfuns calling
Pike.identify_cycle() or Pike.count_memory().

Fixes PIKE-106 (#8106).

7294:    }   ]])    + // Pike.identify_cycle + test_any_equal([[ +  class Foo { Foo next; int counter; }; +  array(Foo) foos = allocate(10, Foo)(); +  for (int i = 0; i < 10; i++) { +  foos[i]->next = foos[(i+1)%10]; +  foos[i]->counter = i; +  } +  return Pike.identify_cycle(foos[0])->counter; + ]], ({ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9 })) + test_any([[ +  // PIKE-106: Mutex not unlocked properly on error in identify_cycle(). +  class Foo { +  int cnt; +  int __hash() { return 0; } +  int `==(mixed x) { if (!cnt++) error("Comparison failure.\n"); } +  }; +  catch { +  // This triggered an error. +  Pike.identify_cycle(allocate(2, Foo)()); +  }; +  catch { +  // This hanged due to the mc_mutex not having been released. +  Pike.identify_cycle(allocate(2, Foo)()); +  }; + ]], 0) +    // Numerical limits.   test_true([[Int.NATIVE_MIN <= -2147483648]])   test_true([[Int.NATIVE_MAX >= 2147483647]])